Skip to content

Add a assign command vehicle behavior#980

Open
Greenscreen23 wants to merge 2 commits intodevfrom
feature/870-allow-vehicles-as-leaders-of-a-simulated-region
Open

Add a assign command vehicle behavior#980
Greenscreen23 wants to merge 2 commits intodevfrom
feature/870-allow-vehicles-as-leaders-of-a-simulated-region

Conversation

@Greenscreen23
Copy link
Contributor

@Greenscreen23 Greenscreen23 commented May 11, 2023

PR Checklist

Please make sure to fulfil the following conditions before marking this PR ready for review:

  • If this PR adds or changes features or fixes bugs, this has been added to the changelog
  • If this PR adds new actions or other ways to alter the state, test scenarios have been added

@Greenscreen23 Greenscreen23 linked an issue May 11, 2023 that may be closed by this pull request
@Greenscreen23
Copy link
Contributor Author

Merge hpi-sam/fuesim-digital-public-test-scenarios#7 after this

@benn02 benn02 self-requested a review May 11, 2023 11:38
benn02
benn02 previously requested changes May 11, 2023
Copy link
Contributor

@benn02 benn02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a line to the UI of the Assign Leader behavior to which vehicle he belongs to Pretty Please (👉 👈 😊
grafik
)

@Greenscreen23 Greenscreen23 force-pushed the feature/870-allow-vehicles-as-leaders-of-a-simulated-region branch from 259e2bf to 84bc8a4 Compare May 12, 2023 11:58
@Greenscreen23 Greenscreen23 requested review from benn02 and removed request for benn02 May 12, 2023 11:59
@Greenscreen23 Greenscreen23 self-assigned this May 12, 2023
@Greenscreen23 Greenscreen23 dismissed benn02’s stale review May 12, 2023 12:00

Refactored the whole codebase

@Nils1729 Nils1729 self-requested a review May 15, 2023 11:42
@Nils1729
Copy link
Contributor

We discussed the design at hand and concluded that since this PR would remove the possibility for a single personnel to lead a region, further discussions are required.

Since the issue is non-critical at the time of writing, the work is deferred for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow vehicles as leaders of a simulated region

3 participants